Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to nonblocking whenever possible #7466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Default to nonblocking whenever possible #7466

wants to merge 1 commit into from

Commits on May 23, 2023

  1. Default to nonblocking whenever possible 

    Ruby 3.0 began to set O_NONBLOCK by default for all IO, to allow more IO
types to enlist in the new IO/fiber scheduling. JRuby has not previously
defaulted to nonblock, but all IO operations against nonblock-compatible
channels does use nonblocking semantics, so all we really need to align
with CRuby is to just set them non-blocking at the NIO level on
creation.

We can only do this when the underlying channel supports
nonblocking semantics, but this commit attempts to set such
channels up properly.

Part of scheduler work in jruby#7459 and related issues.
    @headius
    headius committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0acfadf View commit details
    Browse the repository at this point in the history