Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method! and public_send! for OpenStruct warnings #7524

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Dec 14, 2022

  1. Add method! and public_send! for OpenStruct warnings

    Due to these methods now accessing the caller's scope (for
    refinements) they now warn when being aliased to another name.
    We suppress the warning when the target name has a superset of
    client frame reads, so this patch adds `method!` and
    `public_send!` with SCOPE read.
    
    This is not ideal, since any future method gaining frame fields
    will need to have the same treatment, and other similar methods
    are being skipped by OpenStruct (by our request). However this
    suppresses the warning for now and we can work on a long-term
    option.
    headius committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7db6c18 View commit details
    Browse the repository at this point in the history