-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Binding#dup to properly propagate values it captures #7688
Merged
Commits on Feb 23, 2023
-
Try and appease the eval+binding gods
When we eval with binding we will construct a new binding that contains the original binding and that original binding will construct a new evalDynamicScope. If I do something like: ```ruby p TOPLEVEL_BINDING.local_variable_defined? :c p TOPLEVEL_BINDING.local_variable_defined? :_xxx_var_ b =TOPLEVEL_BINDING.dup p b.local_variable_defined? :c p b.local_variable_defined? :_xxx_var_ ``` I should still see _xxx_var_ after the dup. This will make that do that but two different RubyBinding instances will end up with the exact same backing Binding and I think this is wrong. Landing anyways to see if anything breaks.
Configuration menu - View commit details
-
Copy full SHA for f304def - Browse repository at this point
Copy the full SHA f304defView commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e74990f - Browse repository at this point
Copy the full SHA e74990fView commit details
Commits on May 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4c1473a - Browse repository at this point
Copy the full SHA 4c1473aView commit details -
dup will dup binding state already saved so it will keep variable val…
…ues but they will be their own thing from that point onward
Configuration menu - View commit details
-
Copy full SHA for d994845 - Browse repository at this point
Copy the full SHA d994845View commit details -
bindings can change size..just making sure this fixes issues. I likel…
…y will rename this from dup
Configuration menu - View commit details
-
Copy full SHA for 2b9b9d9 - Browse repository at this point
Copy the full SHA 2b9b9d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cc945b - Browse repository at this point
Copy the full SHA 0cc945bView commit details
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb73e3b - Browse repository at this point
Copy the full SHA eb73e3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fdac51 - Browse repository at this point
Copy the full SHA 1fdac51View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.