[feat] make Ruby#setWarningsEnabled actually useful #7728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when (global) flag is set $VERBOSE should not change it
since otherwise we still end up off by 1 for other warnings
headius
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime.setWarningsEnabled()in it's current form is actually useless given typical Ruby apps usage ofKernel.silence_warningsand$VERBOSE = .... so I tried to re-invent the idea to actually make it useful:setting
runtime.setWarningsEnabled(false)would act as a kill switch (typically in a production env) to avoid nasty surprises esp. with embedded JRuby scenarios - regardless of gems fiddling with$VERBOSEwarnings end up disabled.second I reviewed warning calls to use
warningmethod, have an ID and report proper line number (some were of due the +1/-1 going on) by moving the line adjustment logic to the "source". also,RubyWarningsgot refactored so that the warning/warn calls delegate to pretty much one method as I was thinking of adding agetWarningFilteron the runtime (it's just a few lines to add and works good but I am not yet sure whether it would be worth maintaining given the introduction of the warning gem 馃).