Sock fixes #7729
Merged
Sock fixes #7729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. do not reprocess protocolArg we already have an int 2. unix_path should clean up the string of nul bytes
|
I did these long ago and there is some fallout that needs correcting before it lands. bumping. |
1. IPPROTO_RAW is not in /etc/protocol. Just assume any unknown entry is raw. This seems a little weird but RAW can be for anything so a non-entry can be raw? I have only seen RAW not get found and this is an improvement over what we had. 2. socktype was wrong because when we didn't specify socktype we would use 0 which would return an unknown sock. unknown would return a weird value. Just leave it null in this case.
… can try and call recvmsg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes related to ext/socket