Add more testing for invokedynamic modes #7732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce CI by a few jobs. The general idea is that compatibility-related tests, running in a minimal JRuby mode like fully-interpreted, should be tested on multiple JVMs. Correctness- related tests, like for JIT modes and invokedynamic, can usually be expected to pass the same across JVM versions, and so only need to be tested on one.
headius
force-pushed
the
more_indy_testing
branch
from
b0b9a5a
to
f7694b3
Compare
headius
force-pushed
the
more_indy_testing
branch
from
cad0510
to
70f6c0e
Compare
headius
force-pushed
the
more_indy_testing
branch
from
b020718
to
13a729f
Compare
headius
force-pushed
the
more_indy_testing
branch
from
13a729f
to
853e81c
Compare
There's more work here to do than I want to attack right now, and we may revisit this again with keyword arguments, so there's not a lot of value in fixing current issues.
headius
force-pushed
the
more_indy_testing
branch
2 times, most recently
from
bfb070d
to
d695127
Compare
headius
added a commit
to headius/jruby
that referenced
this pull request
May 18, 2023
This code worked ok to bind user-defined method_missing directly in the InvokeSite, but it breaks the production of a core method missing error by including the symbol name in that exceptions's arguments. We will revisit direct method_missing binding soon, once we refactor how this pipeline delivers arguments to both the exception and to user-defined method_missing methods. Fixes one regression due to invokedynamic, found by enabling more invokedynamic testing in jruby#7732.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will try moving a few CI test suites around, adding invokedynamic to some of them to increase coverage without adding more time.