Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enumerator product #7821

Open
wants to merge 1 commit into
base: ruby-3.2
Choose a base branch
from
Open

enumerator product #7821

wants to merge 1 commit into from

Conversation

gintama91
Copy link

No description provided.

@gintama91
Copy link
Author

hie

I am pavan

this is my first time contributing to jruby

if i did anything wrong pls point it out thankyou

or if there were any necessary tests i should have run or anything! thankyou!

@enebo enebo added this to the JRuby 9.5.0.0 milestone Jun 3, 2023
@enebo
Copy link
Member

enebo commented Jun 3, 2023

@gintama91 Thanks for contributing.

How does this new code get called? I do not see any annotation like @JRubyMethod. I think this should be put on enumeratorProduct (proabably just renamed to "product"). I also believe this making explicit casts to RubyEnumerator may end up potentially causing classcastexceptions with improperly supplied arguments. Test should help figure that out.

For testing I believe there should exist some specs under specs/ruby (although it is possible we have not updated those specs in a while but there should be a enumerator/product_spec.rb somewhere in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants