Remove remaining "19" methods #8149
Conversation
headius
force-pushed
the
remove_remaining_version_methods
branch
from
8e69949
to
4553e9c
Compare
|
A wrinkle here is the use of |
|
I modified the patch in ruby/stringio#84 to work on both old and new methods, so once that is released we can update this PR to use the new stringio version (or just update 9.4 to that version and merge it forward). |
headius
force-pushed
the
remove_remaining_version_methods
branch
2 times, most recently
from
989ade7
to
9529d78
Compare
These methods were not deprecated before JRuby 10, so they were left in place for one additional "major" release. This deletes them. They are very low risk of causing compile or execution problems, but this safer approach gives any remaining users a full version cycle to switch to the long-available normal versions. See jruby#8143 for the original pass that removed already- deprecated methods.
headius
force-pushed
the
remove_remaining_version_methods
branch
from
9529d78
to
725379c
Compare
|
This has been rebased on a merge of master to 9.5-dev and goes back to removing all these methods. The stringio issue will be resolved once a release contains ruby/stringio#84 and ruby/stringio#88, which lets it support both old and new names. We will ship 9.4 with both old and new names, and 9.5 with new names only. |
These methods have been deprecated for some time and we would like to delete them. See jruby/jruby#9143 and jruby/jruby#8149.
These methods have been deprecated for some time and we would like to delete them. See jruby/jruby#9143 and jruby/jruby#8149.
|
A few more method references were found in json: flori/json#576 Once released, that PR will move to versions that exist in JRuby 9.4 so no special gymnastics are required (but we'll need that json released before we can make this change safely). |
These methods were not deprecated before JRuby 10, so they were left in place for one additional "major" release. This deletes them.
They are very low risk of causing compile or execution problems, but this safer approach gives any remaining users a full version cycle to switch to the long-available normal versions.
See #8143 for the original pass that removed already- deprecated methods.