Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a DEFAULT visibility to indicate unspecified #8213

Merged
merged 2 commits into from
May 29, 2024

Commits on Apr 25, 2024

  1. Introduce a DEFAULT visibility to indicate unspecified

    In jruby#8146 we saw that DelegateClass can be broken by
    JRuby extensions that do not explicitly set their initialize
    methods to Visibility.PRIVATE. This is an error-prone requirement
    as detailed in jruby#8210, since there's no indication that
    initialize is special and should always be private.
    
    This patch introduces a "DEFAULT" visibility to be the default for
    the annotation. When binding methods using annotation processing,
    the DEFAULT visibility will translate itself to PRIVATE for the
    initialize method and PUBLIC for other cases. This ensures that
    initialize is always set to PRIVATE if no other visibility is
    specified, avoiding the bug. If initialize is set to some other
    visibility, it will keep that visibility.
    
    Fixes jruby#8210
    headius committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9317c75 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    da0c4df View commit details
    Browse the repository at this point in the history