Process chdir option sooner so execFillarg sees it #8218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit hacky due to the way we handle chdir on top of posix_spawn. The logic for making the command line use sh and cd lives in execFillarg, since it must handle the case where the virtual CWD is not the same as the JVM CWD. In order to make sure that processing also happens for incoming chdir: options, this patch pre-processes the options hash just for chdir. Fixes jruby#8126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit hacky due to the way we handle chdir on top of posix_spawn. The logic for making the command line use sh and cd lives in execFillarg, since it must handle the case where the virtual CWD is not the same as the JVM CWD. In order to make sure that processing also happens for incoming chdir: options, this patch pre-processes the options hash just for chdir.
Fixes #8216