Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subspawn by default for process launching #8221

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

headius
Copy link
Member

@headius headius commented May 1, 2024

The subspawn library is a better and cleaner implementation of Ruby's spawn (and friends) and we should try to move toward using it by default. A few things are needed for this:

  • Enable the replacement spawn and popen (and anything else, like backquotes) to be the ones built on subspawn.
  • Gracefully fall back on the old logic on platforms where subspawn is not supported (Windows, places we have no libfixposix build, inside a complete jar)
  • Bonus: modify subspawn to still function with degraded features on regular non-libfixposix posix_spawn, similar to the old logic but using subspawn's much cleaner argument processing etc.
  • Testing testing testing.

The logic in subspawn is much more complete and passes more specs,
so this is a first step toward using it by default on all
platforms where it works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant