Fix full_message formatting and Throwable impl #8229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
headius
commented
May 8, 2024
headius
commented
- java.lang.Throwable#full_message uses the same logic as Exception#full_message but without #detailed_message it did not include the exception message in output.
- Shared full_message logic did not insert newlines between backtrace lines.
Used by #full_message now for the exception message.
* Check tty only in certain cases (yes for full_message, no for detailed_message) * Pass highlighting from full_message through to detailed_message including tty check.
* Don't append tail if it's empty, because that gives us a rogue newline character.
* Java strings are always unicode, so we should encode as UTF-8 for concatenation. * The resulting encoded string should always be valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.