Fix IO#each_line specs #8240
Merged
Fix IO#each_line specs #8240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringIO and possibly other native extensions do not mark their methods with `keywords=true`. At some future point they should do that and call the newer versions of `getlineCall`. This commit emulates the old behavior in the deprecated methods which will basically accept that a hash in last position is a kwarg. This is not 100% correct but it has not been correct for a long time. So this will not make the compatibility any worse but also will not require a release of stringio in step with JRuby 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix IO#each_line specs
This will also fix a few other incidental methods which share the same code in IO.