Making excluded tests from test/mri/ruby/test_env.rb pass
#8241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edipofederle
force-pushed
the
fix-env-aset
branch
2 times, most recently
from
89023f1
to
9b9be69
Compare
enebo
requested changes
May 17, 2024
There was a problem hiding this comment.
@edipofederle It is great to see you tackling excluded tests in MRI. I think we have lots of broken corner cases like this which need fixing.
edipofederle
force-pushed
the
fix-env-aset
branch
from
9b9be69
to
91b06b2
Compare
edipofederle
changed the title
test/mri/ruby/test_env.rb pass
edipofederle
force-pushed
the
fix-env-aset
branch
from
e4e4c80
to
7372f1c
Compare
edipofederle
force-pushed
the
fix-env-aset
branch
from
7372f1c
to
8f3f8c8
Compare
|
Thanks @edipofederle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making excluded tests from
test/mri/ruby/test_env.rbpass../bin/jruby test/mri/runner.rb test/mri/ruby/test_env.rb