Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve symlinks in user provided $JAVA_HOME #8242

Merged
merged 2 commits into from
May 18, 2024
Merged

Resolve symlinks in user provided $JAVA_HOME #8242

merged 2 commits into from
May 18, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented May 17, 2024

Fixes #8237

@ntkme ntkme mentioned this pull request May 18, 2024
Closed
@headius
Copy link
Member

headius commented May 18, 2024

@mrnoname1000 Could you review? I sent you an invitation to be a collaborator.

mrnoname1000
mrnoname1000 approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@mrnoname1000 mrnoname1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and more correct than the original. Works for me on Debian and Apple Arm.

@headius
Copy link
Member

headius commented May 18, 2024

@ntkme @mrnoname1000 Thanks!

@headius headius added this to the JRuby 9.4.8.0 milestone May 18, 2024
@headius headius merged commit 2ff07a3 into jruby:master May 18, 2024
74 checks passed
@ntkme ntkme deleted the java-home branch May 18, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrnoname1000 mrnoname1000 mrnoname1000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.4.8.0
Development

Successfully merging this pull request may close these issues.

Open3 doesn't write on the right STDOUT
3 participants
@ntkme @headius @mrnoname1000