[Perf] Reduce allocations in ToBits for Plaintext #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <ljedrz@gmail.com>
ljedrz
commented
May 20, 2024
| U8::constant(console::U8::new(members.len() as u8)).write_bits_le(&mut bits_le); | ||
| for (identifier, value) in members { | ||
| let value_bits = value.to_bits_le(); | ||
| identifier.size_in_bits().write_bits_le(&mut bits_le); | ||
| identifier.write_bits_le(&mut bits_le); | ||
| U16::constant(console::U16::new(value_bits.len() as u16)).write_bits_le(&mut bits_le); | ||
| bits_le.extend_from_slice(&value_bits); | ||
| bits_le.extend(value_bits); |
There was a problem hiding this comment.
note: Vec::extend is preferable here, as it avoids cloning the members of of value_bits.
ljedrz
commented
May 20, 2024
| @@ -23,10 +23,12 @@ impl<A: Aleo> ToBits for Plaintext<A> { | |||
| Self::Literal(literal, bits_le) => { | |||
| // Compute the bits of the literal. | |||
| let bits = bits_le.get_or_init(|| { | |||
| let mut bits_le = vec![Boolean::constant(false), Boolean::constant(false)]; // Variant bit. | |||
| let mut bits_le = Vec::new(); | |||
There was a problem hiding this comment.
note: this is a conservative tweak which ensures that the vector starts out with a capacity larger than 2 elements
howardwu
approved these changes
May 20, 2024
|
We need CI here |
iamalwaysuncomfortable
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
Plaintext::write_bits_leare responsible for a large number of allocations when performing deployments and executions; using a few simple tweaks we can reduce that number by as much as ~18% in some scenarios (my run was performed on a large deployment and execution).Also, since we are dealing with
OnceCellhere, the additional calls toVec::shrink_to_fitshould be perfectly acceptable and slightly reduce heap use.