Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Use type_name instead of literals in LiteralType::parse #2459

Merged
merged 1 commit into from
May 23, 2024
Merged

[Refactor] Use type_name instead of literals in LiteralType::parse #2459

merged 1 commit into from
May 23, 2024
+18 −18

Conversation

ljedrz
Copy link
Contributor

@ljedrz ljedrz commented May 21, 2024 •
edited

As discussed here: #2454 (comment). It's a simple refactoring, and due to the use of const fn there will be no difference in performance.

vicsn
vicsn approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@vicsn vicsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When CI is happy I'm happy

@howardwu howardwu merged commit dbc101b into AleoNet:mainnet-staging May 23, 2024
zosorock added a commit that referenced this pull request May 24, 2024
@zosorock
Revert "Merge pull request #2459 from ljedrz/refactor/futureproof_lit…
10ec10d 
…erals"

This reverts commit dbc101b, reversing
changes made to a471281.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardwu howardwu howardwu approved these changes

@vicsn vicsn vicsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ljedrz @howardwu @vicsn