NEW Add option to change all service dates at once #29348
Conversation
|
The run Phan analysis shows an error which comes from the original Dolibarr code. |
Yes, you must pull the last version of branch and solve conflict to have such errors fixed |
eldy
added
the
PR to fix or conflict to solve
eldy
changed the title
| @@ -56,7 +56,24 @@ | |||
| } | |||
|
|
|||
| // Description | |||
| print '<th class="linecoldescription">'.$langs->trans('Description').'</th>'; | |||
| print '<th class="linecoldescription">'.$langs->trans('Description'); | |||
| // @phan-suppress-next-line PhanUndeclaredConstantOfClass | |||
There was a problem hiding this comment.
Can you remove this comment line ? May hide a bug.
There was a problem hiding this comment.
The huge problem is that if I remove this line, the CI/phan check fails.
The second point is that I copy this solution from line 91!
????? What should we do ????? ;)
There was a problem hiding this comment.
Remove the line. If CI/phan check fails after, it means we found a bug to fix. So remove it (i can't do it myself, it seems your repo is not open to external contribution) so we can see what is the error message to have a clue of the bug...
| @@ -56,7 +56,23 @@ | |||
| } | |||
|
|
|||
| // Description | |||
| print '<th class="linecoldescription">'.$langs->trans('Description').'</th>'; | |||
| print '<th class="linecoldescription">'.$langs->trans('Description'); | |||
| if (in_array($object->element, array('propal', 'commande', 'facture', 'order_supplier', 'invoice_supplier')) && $object->status == $object::STATUS_DRAFT) { | |||
There was a problem hiding this comment.
The problem is due to the line
@phan-var-force CommonObject
few line before. It says to phan than $object is CommonObject but it is not, it is Facture or Propal or Commande...
Can you try this workaround:
$constant = get_class($object)."::STATUS_DRAFT";
if (in_array($object->element, array('propal', 'commande', 'facture', 'order_supplier', 'invoice_supplier')) && defined($constant) && $object->status == constant($constant)) {
|
How do you make your push request ? Did you make your commit on an IDE and the create the PR from github or do you edit code from github web ? |
|
The last change you asked me to make I did by editing the file from the github web. |
|
Now it's ready to merge |
Add an icon to the description title
This icon open a form
Before
After
