FIX : Missing hooks extrafields : addExtraField, update, delete #29678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this change the structure and behaviour of the framework, this must be pushed on develop. |
eldy
reviewed
May 15, 2024
|
|
||
| $field_desc = array('type' => $typedb, 'value' => $lengthdb, 'null' => ($required ? 'NOT NULL' : 'NULL'), 'default' => $default); | ||
|
|
||
| if ($type != 'separate') { // No table update when separate type |
eldy
reviewed
May 15, 2024
| @@ -243,13 +243,16 @@ public function __construct($db) | |||
| */ | |||
| public function addExtraField($attrname, $label, $type, $pos, $size, $elementtype, $unique = 0, $required = 0, $default_value = '', $param = '', $alwayseditable = 0, $perms = '', $list = '-1', $help = '', $computed = '', $entity = '', $langfile = '', $enabled = '1', $totalizable = 0, $printable = 0) | |||
| { | |||
| global $hookmanager, $action; | |||
There was a problem hiding this comment.
There is no reason to add $action here to add a missing hook.
eldy
added
the
PR to fix or conflict to solve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX|Fix Missing hooks extrafields : addExtraField, update, delete
I added a few missing hooks to better handle extra fields, because update is here but create and delete no.