Issue 2211. ScalePrecisionValidator error message clarification. #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
nhowell
suggested changes
May 18, 2024
Co-authored-by: Nick Howell <howellnick@gmail.com>
|
@JeremySkinner , @nhowell , thank you for your time! @nhowell , yes this looks better, thank you for suggestion! |
nhowell
approved these changes
May 18, 2024
|
Thanks! I'll aim to get this merged in the next time I've got time to work on FV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #2211, clarified
PrecisionScalevalidator behaviour in docs. Provided a workaround to avoid self contradictory error messages. Also noted inconsistent russian translation of error message in confront to other translations.