Allow gpflow.utilities.triangular() to return FillScaleTriL #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1605 +/- ##
===========================================
- Coverage 95.92% 95.90% -0.03%
===========================================
Files 86 86
Lines 3857 3860 +3
===========================================
+ Hits 3700 3702 +2
- Misses 157 158 +1
Continue to review full report at Codecov.
|
vdutor
reviewed
Nov 18, 2020
| """ | ||
| return tfp.bijectors.FillTriangular() | ||
| if positive_diag: |
There was a problem hiding this comment.
can we not specify a default diag_bijector when positive_diag is set to True?
There was a problem hiding this comment.
Yes, None is using the TFP default (Softplus + Shift(1e-5)), see https://www.tensorflow.org/probability/api_docs/python/tfp/bijectors/FillScaleTriL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type: bugfix / enhancement / new feature / doc improvement
Related issue(s)/PRs:
Summary
Proposed changes
What alternatives have you considered?
Minimal working example
# Put your example code in herePR checklist
make format)make check-all)Release notes
Fully backwards compatible: yes / no
If not, why is it worth breaking backwards compatibility:
Commit message (for release notes):