Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue mentioned in #1708. It seems the
-inf
s in the output were caused due to over-approximation for the bernoulli distribution. If I understand correctly, thenum_gauss_hermite_points
controls the level of approximation using the gaussian quadrature. If this number is high, some of the values during the computation of densities invariational_expectations
is approximated as1.0
(p). Hence, when you compute the log density for bernoulli here, it results inlog(1-p) = log(1-1) = -inf
.I don't think this is a bug, but just a result of over-approximation as specified in the test. I re-run the test several times using
20
and it always passes. Please let me know if this seems reasonable or if you have any other thoughts/suggestions!Thanks!