Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Documentation and Cleaned up Comment View Controller. #1121

Open
wants to merge 2,695 commits into
base: develop
Choose a base branch
from
Open

Adding Documentation and Cleaned up Comment View Controller. #1121

wants to merge 2,695 commits into from

Conversation

Josiah-Agosto
Copy link
Contributor

This request add's documentation and clean's up CommentVC which is an essential part to Slide for Reddit making it easier to navigate this section.

ccrama and others added 30 commits November 1, 2020 16:54
@ccrama
XCode stuff
65d7e1d
@ccrama
Fixed layout bugs with LinkCellView
9e7807d
@ccrama
Make more constraints required
321b1e6
@ccrama
Video loading improvements, Add option to disable Gfycat API
abb6f43
@ccrama
Constraint fixes, Fixed bugs adding swipe from anywhere gesture to Co…
d0da1b7 
…mments and Subreddit VCs
@ccrama
Add new check for endpoint while downloading Reddit videos
4702521
@ccrama
Improve layout of LinkCellView with a simpler view hierarchy, Fixed s…
3951e1e 
…wipe back in CommentViewController
@ccrama
Force shortcuts to reload on settings change
3b9f7e1
@ccrama
Fastlane build v6.0.9
c5a5e3f
@Josiah-Agosto
Added Documentation and Cleaned up Comment View Controller along with…
0149f7a 
… other changes.

This commit has ckeaned up CommentVC making it easier to navigate this section.
@Josiah-Agosto
Fixing some Signing Issues.
4ae7ebd
@Josiah-Agosto
Some more signing Issues.
497f759
@Josiah-Agosto
And more signing.
cd9f8a7
@Josiah-Agosto
And again.
4ee37f0
@Josiah-Agosto
Mhmm.
f0ff637
@Josiah-Agosto
And again.
0cd3d99
@colejd
Fix bundle identifiers, correctly use USR_BASE_IDENTIFIER
2029035
@ccrama
Added 'Sign in with Apple' option to Login page
10c3e28
@ccrama
Cleaned up Sign in with Apple code
f8496d9
@ccrama
Made Sign in with Apple nicer
fd568b0
@ccrama
Fixed frontpage Slide Widgets
1325232
@ccrama
Fixed downloading videos from 3D touch
3002b7f
@ccrama
Fixed layout issues with card padding on ios 13 and below
5172322
@ccrama
Fixed pausing videos in AnyModalVC, Rotation bug fixes with SplitVC, …
525f169 
…Fixed FAB behavior with pinned bottom bar
@Josiah-Agosto
Merge branch 'develop' into documentation_refactoring
d75352c
@ccrama
Fixed rotation in Comments VC
119de98
@ccrama
Fixed searching temporarily getting rid of subreddit colors
078b7f2
@ccrama
Fixed searching temporarily getting rid of subreddit colors
f1fa678
@Josiah-Agosto
Merge branch 'develop' into documentation_refactoring
a82b902
@ccrama
Fixed r/all filters applying to ContentListingVC
cf7bcdb
ccrama and others added 29 commits December 18, 2020 19:30
@ccrama
Code cleanup
16af30b
@ccrama
Added new user menu to Comments
477db1f
@ccrama
Bug fix
8625057
@ccrama
Fixed PostFilter matching previous links
f2b3438
@ccrama
Fixed incorrect frame calculation for previews
f4f1f96
@ccrama
Fixed a few theme issues on iOS 11 and 12
4ed196d
@ccrama
Added v7 Onboarding, TF info
757d2c8
@ccrama
Load low quality Reddit previews, until tapped, and then load high-qu…
9391e32 
…ality version of image. Updates CoreData models, if installed the db needs to be flushed or Slide will crash
@ccrama
Flair overhaul for sidebar and new submissions, Added subreddit rules…
7a605bc 
… to Submit view
@ccrama
Fixed disabling night mode
3d52406
@ccrama
Fixed image loading while offline
e213929
@ccrama
v7 TestFlight build update
06d12fe
@ccrama
Fixed extra spacing before rendered quotes, Fixed videoview not swipi…
bf3c60b 
…ng up to exit in AnyModalVC, Fixed swiping backwards in albums
@Josiah-Agosto
Merge remote-tracking branch 'refs/remotes/origin/develop'
8d310f6 
Conflicts:
	Slide for Reddit/CommentViewController.swift
	Slide for Reddit/Comments/CommentViewController.swift
@Josiah-Agosto
Refactoring some files in Comment VC.
091e108
@ccrama
Bug fixes, Fixed buttons on Inbox and Profile pages, Fixed offset cha…
6064d60 
…nging of tab headers, Fixed paragraph spacing
@ccrama
Fixed paragraph spacing issues
7d231bf
@ccrama
Bug fixed, Improved profile/inbox layouts, Improved text triming for …
9eaec0b 
…NSAttributedString
@ccrama
Merge pull request Haptic-Apps#1142 from ccrama/desktop_mode
9808eaa 
Desktop Mode: Improvements for M1 and Trackpad iPads
@ccrama
Update version number for v7 TF 2, Add build for M1
7e02cdb
@ccrama
Clean up old build folder
70c27b9
@ccrama
Support Git Large Objects, Include build 217 ipa
d8a854e
@ccrama
Podfile update, Fix CI
00b3780
@Josiah-Agosto
Updating this branch.
da120b6
@Josiah-Agosto
Pulling in core_data_rewrite.
d5c1a16
@Josiah-Agosto
Update SubredditToolbarSearchViewController.swift
0f72301
@Josiah-Agosto
Merge remote-tracking branch 'upstream/core_data_rewrite' into core_d…
8e5f65b 
…ata_rewrite
@Josiah-Agosto
Merge branch 'core_data_rewrite' into documentation_refactoring
2f1af1f
@Josiah-Agosto
Update CommentViewController.swift
7b15473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Josiah-Agosto @ccrama @colejd @HiRoS-neko