Enhancement: Added Docker Container Support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nelson-Gon let me know if you have any further questions. |
Closed
Nelson-Gon
approved these changes
May 20, 2023
Nelson-Gon
approved these changes
May 20, 2023
|
Approving as the failing checks are unrelated with the PR, thanks again @jimbrig |
|
@Nelson-Gon Happy to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to resolve issue #3 by adding Docker container support to the application and adding the image container to the github container registry.
See my fork's container here: jimbrig/shinymde - Package shinymde (github.com) for the resulting container.
See the added docker.yml GitHub action and also two development scripts docker.ps1 and docker.sh.