Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally download models if they are not present #8

Open
2 tasks
Nelson-Gon opened this issue Dec 11, 2023 · 0 comments
Open
2 tasks

Optionally download models if they are not present #8

Nelson-Gon opened this issue Dec 11, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers models speech-generation

Comments

@Nelson-Gon
Copy link
Owner

In the current state, the app assumes that the models will always be present and does not test for this assumtion. This would break the app with no feedback to either the users or developers on what could possibly be wrong.

There are two possible ways to deal with this:

  • Always check that the models load, and optionally download them or attempt a download if they do not exist
  • Include the model checkpoints as part of the package and load them internally
@Nelson-Gon Nelson-Gon added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers models speech-generation labels Dec 11, 2023
Nelson-Gon added a commit that referenced this issue Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers models speech-generation
Projects
None yet
Development

No branches or pull requests

1 participant