-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/cortexm_common: make SVC call always available #20603
Open
dylad
wants to merge
4
commits into
RIOT-OS:master
Choose a base branch
from
dylad:pr/cpu/cortexm/remove_svc_module
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Area: build system
Area: Build system
Area: pkg
Area: External package ports
Area: cpu
Area: CPU/MCU ports
labels
Apr 19, 2024
Teufelchen1
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, didn't test it
benpicco
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
May 15, 2024
dylad
force-pushed
the
pr/cpu/cortexm/remove_svc_module
branch
2 times, most recently
from
May 15, 2024 18:43
9d087c9
to
7b79f67
Compare
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
dylad
force-pushed
the
pr/cpu/cortexm/remove_svc_module
branch
from
May 15, 2024 18:56
7b79f67
to
acf9882
Compare
Signed-off-by: dylad <dylan.laduranty@mesotic.com>
I didn't know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: build system
Area: Build system
Area: cpu
Area: CPU/MCU ports
Area: pkg
Area: External package ports
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR proposes to make SVC call always available for user and thus removes the
cortexm_svc
pseudomodule.SVCall is available on all ARMvx-M architecture. This exception was used before to trigger PendSV for the sheduler. Now PendSV is triggered manually and no longer require to use SVCall.
Since the feature was provided by default for all cortexm, I think it makes sense to remove the pseudomodule and to let it hardcoded in the code.
Testing procedure
CI should be happy.
Issues/PRs references
None.