feat: high contrast theme #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgantzos
requested changes
Nov 24, 2022
features/forced-dark-mode.js
Outdated
Comment on lines
16
to
17
| background-color: invert(100%); | ||
| color: invert(100%); |
There was a problem hiding this comment.
You can't use a filter on a color. If you used something like document.body.style.filter = 'invert(1)', it would technically work, but images would have their color inverted, and the inverts of many Scratch colors just don't look that great.
|
@rgantzos requested changes implemented |
rgantzos
reviewed
Nov 24, 2022
|
@rgantzos Alright, images are inverted a second time so that they uninvert. |
|
@rgantzos I think its best to call this feature high contrast. |
|
I'll work on a few changes just to keep some of the basic elements normal. |
|
when will this be finished? |
|
Forgot about this PR |
Lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.