Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Project Tags #747

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Consolidate Project Tags #747

wants to merge 4 commits into from

Conversation

MaterArc
Copy link
Member

@MaterArc MaterArc commented Nov 6, 2023

Removes duplicate project tags from the instruction and credit box.

@MaterArc
Consolidate Project Tags
aa00383 
Removes duplicate project tags from the instruction and credit box.
@MaterArc
Update features.json
c3399c5
@MaterArc MaterArc added the new feature Adds a new feature to the settings page label Nov 6, 2023
@MaterArc MaterArc added this to the ScratchTools v3.5.0 milestone Nov 6, 2023
callumjt
callumjt approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@callumjt callumjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

rgantzos
rgantzos requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@rgantzos rgantzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using the feature module and waiting for elements instead of waiting for page load. You should also look for <a> elements via a query selector instead of the innerHTML.

@rgantzos rgantzos removed this from the ScratchTools v3.5.0 milestone Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgantzos rgantzos rgantzos requested changes

@callumjt callumjt callumjt approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new feature Adds a new feature to the settings page priority #3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaterArc @rgantzos @callumjt