Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Be more specific and a few (other) fixes #759

Merged
merged 13 commits into from
Mar 26, 2024

Conversation

OneShot-Niko
Copy link
Contributor

@OneShot-Niko OneShot-Niko commented Dec 9, 2023

EDIT

Should be done, waiting for review.
Nevermind - Gonna do one last commit beforehand (cant convert to draft due to mobile)

Ready for review (again)

Changes on #Installing

  1. Rewords a few things that are worded weirdly.
  2. Mentions Vivaldi (Chromium Fork) as an example of using the Chrome Webstore on a Chromium fork to install ScratchTools
  3. Adds small tutorial on how to install from source on Firefox ahead of time, including a > [!WARNING] note that reminds users extensions loaded that way are indeed temporary and gone when the browser is closed, and again reminds that ScratchTools is outdated on Firefox (that part of the warning can be removed, though if needed that can be kept out or just in-general edited) and the extension currently cannot load.
  4. Mentions installing with Git - I may have messed up the syntax so that might need correcting.

Changes on #Building-a-Feature

Remove unneccasary extra space before "XCode".

Changes on "How to help without coding"

Mentions the community discord server as well instead of only the feedback page (if needed this can be edited out)

Other

Fixes a broken section by adding a missing dash (required due to a comma) (Thank you to ajskateboarder for helping me notice how to fix, I was Scratching my head around that for a bit!)
URL-Related:

  1. "Report a Bug" (Old URL) didn't assign the bug label automatically from what I can tell - Now it should.
  2. Reporting bugs (without Github)/security vulnerabilities in the README.md & SECURITY.md (Old URL) had outdated URLs, they used /bugs instead of /feedback - PR fixes that. Should be every instance (which is only the SECURITY and README file last I checked)

EDIT: Apparently I broke the section with something, gonna try getting a fix on it.
EDIT2: Resolved it.

For now includes > [!WARNING] as to help make the fact that extensions loaded this way are indeed temporary and gone when the browser is closed, still mentions the fact that the extension on Firefox is outdated, however still provided there just so it wouldn't need to be re-added.
@OneShot-Niko OneShot-Niko changed the title README.md: be more specific & a few other changes README.md: be more specific, fix Sound, GUI and Paint-Mode section (ty ajskateboarder) & few minor changes Dec 9, 2023
@OneShot-Niko OneShot-Niko changed the title README.md: be more specific, fix Sound, GUI and Paint-Mode section (ty ajskateboarder) & few minor changes README.md: be more specific, fix Sound, GUI and Paint-Mode section (ty ajskateboarder) & a few minor changes Dec 9, 2023
Should be one of the last changes to this part I hope.
Corrects the "Report a Bug" URL (bug label should get assigned by default from that URL now) and replaces "https://scratchtools.app/bugs" with "https://www.scratchtools.app/feedback/"
@OneShot-Niko OneShot-Niko changed the title README.md: be more specific, fix Sound, GUI and Paint-Mode section (ty ajskateboarder) & a few minor changes README.md: Be more specific and a few fixes Dec 9, 2023
@OneShot-Niko OneShot-Niko changed the title README.md: Be more specific and a few fixes README.md: Be more specific and a few fixes (eg. fix Sound, GUI and Paint-Mode direct in Table of Contents) Dec 9, 2023
@OneShot-Niko OneShot-Niko changed the title README.md: Be more specific and a few fixes (eg. fix Sound, GUI and Paint-Mode direct in Table of Contents) README.md: Be more specific and a few (other) fixes (eg. fix Sound, GUI and Paint-Mode direct in Table of Contents) Dec 10, 2023
@OneShot-Niko OneShot-Niko changed the title README.md: Be more specific and a few (other) fixes (eg. fix Sound, GUI and Paint-Mode direct in Table of Contents) README.md: Be more specific and a few (other) fixes in a few files Dec 10, 2023
@OneShot-Niko OneShot-Niko changed the title README.md: Be more specific and a few (other) fixes in a few files README.md: Be more specific and a few (other) fixes Dec 10, 2023
@OneShot-Niko
Copy link
Contributor Author

Any updates on this being reviewed?

Apologies if I'm just being impatient here.

@Daniel4-Scratch
Copy link
Member

@rgantzos I think you should have a look

might have messed up the syntax since I am currently on mobile - That might need to be corrected
@OneShot-Niko
Copy link
Contributor Author

OneShot-Niko commented Mar 26, 2024

@rgantzos sorry for the bother, though could this be reviewed?

Edut: Thank you for both the changes and the merge!

@rgantzos rgantzos merged commit 0bd553c into STForScratch:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants