-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md
: Be more specific and a few (other) fixes
#759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code" opening pr in a few mins
For now includes > [!WARNING] as to help make the fact that extensions loaded this way are indeed temporary and gone when the browser is closed, still mentions the fact that the extension on Firefox is outdated, however still provided there just so it wouldn't need to be re-added.
OneShot-Niko
changed the title
Dec 9, 2023
README.md
: be more specific & a few other changesREADME.md
: be more specific, fix Sound, GUI and Paint-Mode
section (ty ajskateboarder) & few minor changes
OneShot-Niko
changed the title
Dec 9, 2023
README.md
: be more specific, fix Sound, GUI and Paint-Mode
section (ty ajskateboarder) & few minor changesREADME.md
: be more specific, fix Sound, GUI and Paint-Mode
section (ty ajskateboarder) & a few minor changes
Should be one of the last changes to this part I hope.
Corrects the "Report a Bug" URL (bug label should get assigned by default from that URL now) and replaces "https://scratchtools.app/bugs" with "https://www.scratchtools.app/feedback/"
OneShot-Niko
changed the title
Dec 9, 2023
README.md
: be more specific, fix Sound, GUI and Paint-Mode
section (ty ajskateboarder) & a few minor changesREADME.md
: Be more specific and a few fixes
OneShot-Niko
changed the title
Dec 9, 2023
README.md
: Be more specific and a few fixesREADME.md
: Be more specific and a few fixes (eg. fix Sound, GUI and Paint-Mode
direct in Table of Contents)
OneShot-Niko
changed the title
Dec 10, 2023
README.md
: Be more specific and a few fixes (eg. fix Sound, GUI and Paint-Mode
direct in Table of Contents)README.md
: Be more specific and a few (other) fixes (eg. fix Sound, GUI and Paint-Mode
direct in Table of Contents)
OneShot-Niko
changed the title
Dec 10, 2023
README.md
: Be more specific and a few (other) fixes (eg. fix Sound, GUI and Paint-Mode
direct in Table of Contents)README.md
: Be more specific and a few (other) fixes in a few files
OneShot-Niko
changed the title
Dec 10, 2023
README.md
: Be more specific and a few (other) fixes in a few filesREADME.md
: Be more specific and a few (other) fixes
Any updates on this being reviewed? Apologies if I'm just being impatient here. |
@rgantzos I think you should have a look |
might have messed up the syntax since I am currently on mobile - That might need to be corrected
@rgantzos sorry for the bother, though could this be reviewed? Edut: Thank you for both the changes and the merge! |
rgantzos
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT
Should be done, waiting for review.Nevermind - Gonna do one last commit beforehand (cant convert to draft due to mobile)
Ready for review (again)
Changes on #Installing
> [!WARNING]
note that reminds users extensions loaded that way are indeed temporary and gone when the browser is closed, and again reminds that ScratchTools is outdated on Firefox (that part of the warning can be removed, though if needed that can be kept out or just in-general edited) and the extension currently cannot load.Changes on #Building-a-Feature
Remove unneccasary extra space before "XCode".
Changes on "How to help without coding"
Mentions the community discord server as well instead of only the feedback page (if needed this can be edited out)
Other
Fixes a broken section by adding a missing dash (required due to a comma) (Thank you to ajskateboarder for helping me notice how to fix, I was Scratching my head around that for a bit!)
URL-Related:
README.md
&SECURITY.md
(Old URL) had outdated URLs, they used /bugs instead of /feedback - PR fixes that. Should be every instance (which is only the SECURITY and README file last I checked)EDIT: Apparently I broke the section with something, gonna try getting a fix on it.
EDIT2: Resolved it.