Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature "project-words-filter" #783

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

Masaabu
Copy link

@Masaabu Masaabu commented Feb 13, 2024

Remove or blur from the search page any projects that contain words you do not want to appear in the title.

Masaabu and others added 3 commits February 14, 2024 06:24
Remove the case-sensitive aspect of removing or blurring filter words.
@MaterArc
Copy link
Member

Looks good so far! This seems like a nice feature, I did, however, make a couple of changes to make it even better! I noticed some more tiny things that I will try to fix later this evening and hopefully we can get this in as a version feature soon!

"dynamic": true,
"options": [
{ "id": "blur", "name": "Blur thumbnails without erasing the project.", "type": 1 },
{ "id": "filter-words", "name": "filter words (Split by comma)", "type": 0 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be a better idea to allow users to set the words each time they search, as it isn't always the same for each search. Maybe a little input where they can add words like tags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's not a bad idea...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? image

Looks pretty neat! A lot going on there, but that can be cleaned up later...

@MaterArc
Copy link
Member

The filter input box should also support spaces in between items. When seeing that they are separated by commas, it should also allow spaces.

@Masaabu
Copy link
Author

Masaabu commented Feb 21, 2024

Currently, the filter only works for project titles. Do we need the ability to filter by user name as well?

@MaterArc MaterArc added the new feature Adds a new feature to the settings page label Feb 22, 2024
@mrrfyW
Copy link
Contributor

mrrfyW commented Apr 1, 2024

I was just thinking about making a feature like this! This was kinda done with Anti-Generic, but it would be great if they were able to be specified by the user.

Also, what if this feature makes it so the user can decide which keywords need their thumbnails blurred or the projects filtered, as well as another thing where it gets the instructions/description of the project via the https://api.scratch.mit.edu requests made when using the explore/search page and removes them based on those descriptions as well? I think both of those additions would make this feature better.

Oh, and also make a version for the studios page and user accounts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Adds a new feature to the settings page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants