Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the most of metadata into PEP 621-compliant pyproject.toml. #1006

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Feb 12, 2023

Requires #1005

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #1006 (232b631) into devel (f63ed48) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1006   +/-   ##
=======================================
  Coverage   54.49%   54.49%           
=======================================
  Files         210      210           
  Lines       21560    21560           
  Branches     3169     3169           
=======================================
  Hits        11750    11750           
  Misses       9255     9255           
  Partials      555      555           

@vnmabus
Copy link

vnmabus commented Sep 26, 2023

It partially overlaps with #975, I think.

@MartinBubel
Copy link
Contributor

I like it! What do you think @ekalosak @lawrennd ? Should merge this (after resolving conflicts etc) into the upcoming release or keep it for the subsequent one with more updates/qof-fixes?

@lawrennd
Copy link
Member

lawrennd commented Oct 5, 2023

I'd be supportive of this.

@ekalosak
Copy link
Contributor

ekalosak commented Dec 6, 2023

Yes pls update the branch and we need to merge it.

@MartinBubel MartinBubel self-assigned this Mar 23, 2024
Copy link
Contributor

@MartinBubel MartinBubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some minor things to be done

authors = [{name = "GPy Authors: https://github.com/SheffieldML/GPy/graphs/contributors", email = "gpy.authors@gmail.com"},]
license = {text = "BSD-3-Clause"}
description = "The Gaussian Process Toolbox"
readme = "README.rst"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
readme = "README.rst"
readme = "README.md"

Comment on lines +18 to +22
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",

Comment on lines +34 to +35
"scipy>=1.3.0; python_version >= '3.6'",
"scipy>=1.3.0,<1.5.0; python_version < '3.6'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"scipy>=1.3.0; python_version >= '3.6'",
"scipy>=1.3.0,<1.5.0; python_version < '3.6'",
"scipy>=1.3.0,<=1.12.0"

dependencies = [
"numpy>=1.7",
"six",
"paramz>=0.9.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"paramz>=0.9.0",
"paramz>=0.9.6",

Comment on lines +49 to +50
"matplotlib==3.3.4; python_version >= '3.6'",
"matplotlib==3.0.0; python_version < '3.6'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"matplotlib==3.3.4; python_version >= '3.6'",
"matplotlib==3.0.0; python_version < '3.6'",
"matplotlib>=3.3.4",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants