Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Mode init in _ready #122

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JEuler
Copy link

@JEuler JEuler commented Aug 8, 2023

Hey, cool addon! I found a problem when I was using it. I've tried to upload results in my own Autoload script and found that PlayfabManager is not working in Pause mode. Is that made intentionally?

@Structed
Copy link
Owner

Structed commented Aug 9, 2023

Thank you very much for your contribution, @JEuler!
In fact, I never thought about pause mode, so the change is much appreciated!

I would, however, ask you to add a test example to the Example Scenes. Could you do that?

@JEuler
Copy link
Author

JEuler commented Aug 10, 2023

Hey! Thanks! But I don't know what to do in the text example scene for this change. I just faced an issue, that when you have get_tree().paused = true - my own helper class which used the PlayFabManager stopped working. I have added this line to my own class at first with no luck, but after some thinking - I come up with this solution and all worked.

@JEuler
Copy link
Author

JEuler commented Aug 22, 2023

Hey! Should I just create test example where I pause something, and the Plugin stopped working? :)

@Structed
Copy link
Owner

Structed commented Oct 7, 2023

I am so sorry for the long wait! life and not reading my notifications cam in between 😬

Well, I imagine a pause button, while in the background you can still see the checks for whether events are batched to be sent (shown in console).

Another thing to consider is, that the mode should really be settable by the developer via the Plugin config. But I suppose that can be a separate task.

@Structed
Copy link
Owner

Structed commented Oct 7, 2023

Thinking about this more: this change would introduce a breaking change. In order to not make this breaking, this must be a project setting that defaults to PROCESS_MODE_INHERIT.

@Structed Structed self-requested a review December 18, 2023 09:43
@Structed Structed linked an issue Dec 18, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore Pause
2 participants