-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Login With Steam #132
base: develop
Are you sure you want to change the base?
Add: Login With Steam #132
Conversation
c45cf90
to
14fe86f
Compare
I created an Issue (#133) corresponding to the PR, I forgot to add an example for the Steam Auth Ticket For Web API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few bits of nitpicking, but overall really nice, thank you!
I feel like this and the actual integration (with the code you have in the docs) should be it's own |
…with method _on_login)
8e65a28
to
6307292
Compare
Hi, the feature can be tested on my branch tests/login_with_steam. I didn't put it with the feature to avoid importing external extension in the main branch.