Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add needConfirm option on time-picker docs #48945

Merged
merged 9 commits into from
May 19, 2024

Conversation

KumJungMin
Copy link
Sponsor Contributor

@KumJungMin KumJungMin commented May 16, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

💡 Background and solution

  • The needConfirm option added at v5.14.0 .

| needConfirm | Need click confirm button to trigger value change | boolean | - | 5.14.0 |

  • but, the option demo and description is blank.

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented May 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 16, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 16, 2024

👁 Visual-Regression Diff Building... ⏳

This PR is under visual-regression-diff building, please wait for the result.

Copy link

codesandbox-ci bot commented May 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@KumJungMin KumJungMin requested a review from afc163 May 16, 2024 03:18
@afc163
Copy link
Member

afc163 commented May 16, 2024

ci broken

@KumJungMin KumJungMin force-pushed the docs/time-picker-need-confirm branch from 366dfca to 4641b42 Compare May 16, 2024 23:10
@KumJungMin
Copy link
Sponsor Contributor Author

@afc163 I resolved the CI error caused by missing test snapshots 😄 (4641b42)

afc163
afc163 previously approved these changes May 17, 2024
@afc163
Copy link
Member

afc163 commented May 18, 2024

CI broken

@KumJungMin KumJungMin force-pushed the docs/time-picker-need-confirm branch from eca87aa to 223b078 Compare May 18, 2024 11:27
@afc163
Copy link
Member

afc163 commented May 18, 2024

@afc163
Copy link
Member

afc163 commented May 18, 2024

Run npm test -- components/time-picker -u to update snapshot.

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b62b819) to head (4c4780b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48945   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        12977     12977           
  Branches      3403      3403           
=========================================
  Hits         12977     12977           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 84ee56f into ant-design:master May 19, 2024
60 of 61 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@KumJungMin KumJungMin deleted the docs/time-picker-need-confirm branch May 19, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants