GUACAMOLE-377: Add client-side support for frame tracking and RemoteFX parameter. #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
requested changes
Feb 13, 2022
extensions/guacamole-display-statistics/src/main/resources/directives/guacClientStatistics.js
Outdated
Show resolved
Hide resolved
extensions/guacamole-display-statistics/src/main/resources/directives/guacClientStatistics.js
Outdated
Show resolved
Hide resolved
mike-jumper
force-pushed
the
rdp-rfx-frame-statistics
branch
from
fecd14a
to
6dfb4f5
Compare
mike-jumper
force-pushed
the
rdp-rfx-frame-statistics
branch
from
6dfb4f5
to
be90de9
Compare
|
What does the toolbar actually look like? Can you post a screenshot to this PR? |
|
Sure - I'll deploy a copy and grab a screenshot. |
|
The toolbar from the extension is added to the bottom of the client view and looks like this:
It shows the rate that frames are being received from the remote desktop, the rate that the Guacamole server is processing received frames, the rate that the Guacamole client is rendering frames, and the rate that the Guacamole server is having to drop frames to compensate for processing delays on the client or server. |
jmuehlner
approved these changes
Jun 13, 2022
|
Awesome! Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding to apache/guacamole-server#363, this change adds support for enhanced frame tracking, an extension which implements that tracking and renders performance metrics in a toolbar, and the usual parameter definitions and translations.