Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-990: Ensure internal errors during auth reach global error handling/logging. #762

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

mike-jumper
Copy link
Contributor

The recent changes adding support for automatically banning IP addresses that repeatedly fail to authenticate (#758) have resulted in the details of internal errors being omitted from the Tomcat logs, instead being logged as “User authentication was aborted”.

For example, if PostgreSQL is being used but the database server has not been started, the following is logged:

12:12:59.935 [http-nio-8080-exec-2] WARN  o.a.g.e.AuthenticationProviderFacade - The "postgresql" authentication provider has encountered an internal error which will halt the authentication process. If this is unexpected or you are the developer of this authentication provider, you may wish to enable debug-level logging. If this is expected and you wish to ignore such failures in the future, please set "skip-if-unavailable: postgresql" within your guacamole.properties.
12:12:59.949 [http-nio-8080-exec-2] ERROR o.a.g.rest.RESTExceptionMapper - Request could not be processed: User authentication was aborted.

These changes rethrow the underlying cause when authentication fails due to an unchecked internal error. For other errors (subclasses of GuacamoleException), the original underlying exception is unwrapped and rethrown as before.

@jmuehlner jmuehlner merged commit b2d7b83 into apache:master Sep 28, 2022
@mike-jumper mike-jumper deleted the fix-log-masking branch September 28, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants