Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposes addButton and setValue #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jmej
Copy link

@jmej jmej commented Oct 26, 2022

This functionality copies the work kabrio did in their fork:
master...kabrio:p5.gui:master

but updates setRangeValue to setValue so that it works with the latest quickSettings

@jmej
Copy link
Author

jmej commented Oct 26, 2022

This is pretty important functionality - it looks like @kabrio also did a pull request when the original work was done but it wasn't merged. I hope this gets merged to prevent future un-needed forks

@jmej
Copy link
Author

jmej commented Nov 2, 2022

this would close #21 #13 and #5

I wonder if it can be merged as a stop-gap while a more magic version is considered? I'm not sure what a magic version would exactly look like - so this feels like a practical solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant