Sort languages alphabetically (#15)

.github/workflows/ci.yml

@@ -41,7 +41,7 @@ jobs:
 
       - run: poetry install
       - name: Test
-        run: poetry run pytest
+        run: poetry run pytest --cov --cov-fail-under=73
       - run: ${{ matrix.CMD_BUILD }}
       - uses: actions/upload-artifact@v3
         with:

.gitignore

@@ -2,3 +2,4 @@ dist/
 __pycache__/
 build/
 .pytest_cache/
+.coverage

Makefile

@@ -8,6 +8,9 @@ bundle_windows:
 	make buzz
 	tar -czf dist/buzz-${version}-windows.tar.gz dist/Buzz
 
+test:
+	pytest --cov --cov-fail-under=73
+
 bundle_mac:
 	make buzz
 	tar -czf dist/buzz-${version}-unix.tar.gz dist/Buzz

gui.py

@@ -59,14 +59,21 @@ class LanguagesComboBox(QComboBox):
 
     def __init__(self, default_language: str, *args) -> None:
         super().__init__(*args)
-        self.languages = {'': 'Detect language', **tokenizer.LANGUAGES}
-        self.addItems(map(lambda lang: lang.title(), self.languages.values()))
+
+        whisper_languages = sorted(
+            [(lang, tokenizer.LANGUAGES[lang].title())
+             for lang in tokenizer.LANGUAGES.keys()],
+            key=lambda lang: lang[1])
+        self.languages = [('', 'Detect Language')] + whisper_languages
+
+        self.addItems([lang[1] for lang in self.languages])
         self.currentIndexChanged.connect(self.on_index_changed)
-        self.setCurrentText(self.languages.get(default_language, '').title())
+        default_language_index = next((i for i, lang in enumerate(self.languages)
+                                       if lang[0] == default_language), 0)
+        self.setCurrentIndex(default_language_index)
 
     def on_index_changed(self, index: int):
-        key = list(self.languages.keys())[index]
-        self.languageChanged.emit(key)
+        self.languageChanged.emit(self.languages[index][0])
 
 
 class TasksComboBox(QComboBox):

gui_test.py

@@ -0,0 +1,23 @@
+from gui import Application, LanguagesComboBox
+
+
+class TestApplication:
+    app = Application()
+
+    def test_should_show_window_title(self):
+        assert self.app.window.windowTitle() == 'Buzz'
+
+
+class TestLanguagesComboBox:
+    languagesComboxBox = LanguagesComboBox('en')
+
+    def test_should_show_sorted_whisper_languages(self):
+        assert self.languagesComboxBox.itemText(0) == 'Detect Language'
+        assert self.languagesComboxBox.itemText(10) == 'Belarusian'
+        assert self.languagesComboxBox.itemText(20) == 'Dutch'
+        assert self.languagesComboxBox.itemText(30) == 'Gujarati'
+        assert self.languagesComboxBox.itemText(40) == 'Japanese'
+        assert self.languagesComboxBox.itemText(50) == 'Lithuanian'
+
+    def test_should_select_default_language(self):
+        assert self.languagesComboxBox.currentText() == 'English'

pyproject.toml

@@ -22,6 +22,7 @@ autopep8 = "^1.7.0"
 pyinstaller = "^5.4.1"
 six = "^1.16.0"
 pytest = "^7.1.3"
+pytest-cov = "^4.0.0"
 
 [build-system]
 requires = ["poetry-core"]