Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create national-library-of-medicine-grant-proposals-all-names-doi-pmi… #7013

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

masterrite
Copy link

There are people who prefer to list all of DOI, PMID, and PMCID at the end of each reference entry. NIH grants also forbids URL in bibliography, and some papers would show up URLs as source.

This is based on national-library-of-medicine-grant-proposals. I'm also happy to have this merged to that one, but I would appreciate helps (this is my first time doing GitHub PRs and creating Zotero styles)

…d-pmcid

There are people who prefer to list all of DOI, PMID, and PMCID at the end of each reference entry. NIH grants also forbids URL in bibliography, and some papers would show up URLs as source.

This is based on national-library-of-medicine-grant-proposals. I'm also happy to have this merged to that one, but I would appreciate helps (this is my first time doing GitHub PRs and creating Zotero styles)
…d-pmcid to national-library-of-medicine-grant-proposals-all-names-doi-pmid-pmcid.csl
Copy link

😟 There are some issues with your submission.

2 tests failed

national-library-of-medicine-grant-proposals-all-names-doi-pmid-pmcid: must define all macros that are called by <text/> and <key/> elements

expected `{"DOI"=>#<CSL::Style::Macro name="DOI" children=[1]>, "author"=>#<CSL::Style::Macro name="author" chi...:Macro name="report-details" children=[1]>, "title"=>#<CSL::Style::Macro name="title" children=[2]>}.has_key?("accessed-date")` to be truthy, got false

national-library-of-medicine-grant-proposals-all-names-doi-pmid-pmcid: "self" link must match the style ID

expected: "http://www.zotero.org/styles/national-library-of-medicine-grant-proposals"
     got: "http://www.zotero.org/styles/national-library-of-medicine-grant-proposals-all-names-doi-pmid-pmcid"

(compared using ==)

Please check the test report for details.

…d-pmcid.csl

Not sure how to fix " 1) national-library-of-medicine-grant-proposals-all-names-doi-pmid-pmcid: must define all macros that are called by <text/> and <key/> elements
     Failure/Error: expect(style.macros).to have_key(node[:macro])". But I hope I did fix 2) national-library-of-medicine-grant-proposals-all-names-doi-pmid-pmcid: "self" link must match the style ID
…d-pmcid.csl

Fixed PMID showing twice when PMCID is absent
Copy link

😟 There are some issues with your submission.

1 test failed

national-library-of-medicine-grant-proposals-all-names-doi-pmid-pmcid: must define all macros that are called by <text/> and <key/> elements

expected `{"DOI"=>#<CSL::Style::Macro name="DOI" children=[1]>, "author"=>#<CSL::Style::Macro name="author" chi...:Macro name="report-details" children=[1]>, "title"=>#<CSL::Style::Macro name="title" children=[2]>}.has_key?("accessed-date")` to be truthy, got false

Please check the test report for details.

Copy link

😟 There are some issues with your submission.

1 test failed

national-library-of-medicine-grant-proposals-all-names-doi-pmid-pmcid: must define all macros that are called by <text/> and <key/> elements

expected `{"DOI"=>#<CSL::Style::Macro name="DOI" children=[1]>, "author"=>#<CSL::Style::Macro name="author" chi...:Macro name="report-details" children=[1]>, "title"=>#<CSL::Style::Macro name="title" children=[2]>}.has_key?("accessed-date")` to be truthy, got false

Please check the test report for details.

…d-pmcid.csl

changed summary to reflect the actual function of this style
Copy link

😟 There are some issues with your submission.

1 test failed

national-library-of-medicine-grant-proposals-all-names-doi-pmid-pmcid: must define all macros that are called by <text/> and <key/> elements

expected `{"DOI"=>#<CSL::Style::Macro name="DOI" children=[1]>, "author"=>#<CSL::Style::Macro name="author" chi...:Macro name="report-details" children=[1]>, "title"=>#<CSL::Style::Macro name="title" children=[2]>}.has_key?("accessed-date")` to be truthy, got false

Please check the test report for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant