Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multivariate_normal.py to use loc instead of mean #2488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisyeh96
Copy link
Contributor

Update MultivariateNormal to better match torch.distributions.MultivariateNormal

Also, add typing annotation that allows loc to be a LinearOperator

Update MultivariateNormal to better match torch.distributions.MultivariateNormal

Also, add typing annotation that allows `loc` to be a LinearOperator
@Balandat
Copy link
Collaborator

Thanks. I expect this to cause some backward compatibility problems though, e.g. here in BoTorch. Not sure if it's worth the trouble of changing this in a way that deprecates the old arg name, but that's something you could do if you feel strongly about the renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants