install_deps doesn't fail if package installation fails

[krlmlr]

https://travis-ci.org/krlmlr/ProjectTemplate/builds/13674885

use options(warn=2)?

[craigcitro]

that sounds right to me, but maybe we should ask @hadley if that's going to cover everything.

[hadley]

That seems like a reasonable approach to me, but I don't know enough about the behaviour of install.packages to say for sure (there's probably no foolproof way to capture every error scenario)

[craigcitro]

@krlmlr would you be willing to patch this in and try it on that same repo when you get a chance?

[krlmlr]

Same for this -- we could extend our .travis.yml to test that installing, say, rJava, without installing its prerequisites.

[craigcitro]

So just adding the warn=2 seems to break anyone who's depending on non-CRAN packages, so that's no good. We're going to have to think of something slicker.

[craigcitro]

link to the failure:
https://travis-ci.org/craigcitro/r-travis/builds/14457432

[krlmlr]

I guess that's just another breaking change -- people will have to move the code that installs non-CRAN repos before install_deps. Good thing is, we can estimate the damage done in advance: https://github.com/search?l=YAML&q=travis-tool.sh+install_deps&ref=advsearch&type=Code .

[craigcitro]

that won't work - it also fails for non-cran r repos. I think a better
failure message is easier here.

---

-cc

sent from my phone
On Nov 24, 2013 1:58 PM, "Kirill Müller" notifications@github.com wrote:

I guess that's just another breaking change -- people will have to move
the code that installs non-CRAN repos before install_deps. Good thing is,
we can estimate the damage done in advance:
https://github.com/search?l=YAML&q=travis-tool.sh+install_deps&ref=advsearch&type=Code.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/74#issuecomment-29167410
.