treat warnings in install.packages as errors #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now I see what you mean... Amending. |
|
The test now tests what it's supposed to test. Do we want warnings in |
|
bump Warnings in |
|
I like adding it behind a flag -- how about a new one? (i imagine "my dependencies are having issues" being a separate worry from "i have warnings in my package".) |
added 8 commits
November 26, 2014 10:13
Conflicts: scripts/travis-tool.sh
…STALL_ERRORS is nonempty
|
Updated to current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warnings in
install_depsare tolerated.This won't fix no #74, but still could be useful.