-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support github release #135
Open
luckyrandom
wants to merge
15
commits into
craigcitro:master
Choose a base branch
from
luckyrandom:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -266,6 +266,26 @@ RunTests() { | |||
fi | |||
} | |||
|
|||
BootstrapDeploy() { | |||
if [[ -z ${BOOTSTRAP_DEPLOY_COMPLETE} ]]; then | |||
curl -OL http://raw.github.com/luckyrandom/r-travis/master/scripts/github-release.rb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably luckyrandom
should be changed to craigcitro
here, at least after merging.
As suggested by krlmlr, environment will not be propagated to the calling shell. Since deploy script should be called only once, we don't really need to protect BootstrapDeploy from multiple running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add support for github release, which was requested in #124. Please feel free to move the following doc to any place such as wiki. You may check https://travis-ci.org/luckyrandom/r-travis-test/builds for a working example.
Release package on github release
Set up
the document on travis-ci,
by running the following command in the project directory
.travis.yml
Recommend workflow
When a package is ready, bump the version, and put
[try deploy github]
in a single line of commit comment. Then the deploy script will create release and upload pkg automatically. In detail, the deploy script will create a release on github if the build pass, which will trigger another build on Travis-CI, in which the deploy script will upload the package.Alternatively, you can also trigger the deploy script to upload package by,