Merge pull request #148 from datalad/pytest

Switch from nose to pytest

.appveyor.yml

@@ -78,7 +78,7 @@ environment:
     # MacOS core tests
     - ID: MacP38core
       DTS: datalad_xnat
-      APPVEYOR_BUILD_WORKER_IMAGE: macOS
+      APPVEYOR_BUILD_WORKER_IMAGE: macos-monterey
       PY: 3.8
       INSTALL_GITANNEX: git-annex
       DATALAD_LOCATIONS_SOCKETS: /Users/appveyor/DLTMP/sockets
@@ -183,10 +183,8 @@ test_script:
   - cmd: md __testhome__
   - sh: mkdir __testhome__
   - cd __testhome__
-    # run test selecion (--traverse-namespace needed from Python 3.8 onwards)
-  - cmd: python -m nose --traverse-namespace -s -v -A "not (turtle)" --with-cov --cover-package datalad_xnat %DTS%
-  - sh:  python -m nose --traverse-namespace -s -v -A "not (turtle)" --with-cov --cover-package datalad_xnat ${DTS}
-
+  - cmd: python -m pytest -s -v -m "not (turtle)" --cov=datalad_xnat --pyargs %DTS%
+  - sh: python -m pytest -s -v -m "not (turtle)" --cov=datalad_xnat --pyargs ${DTS}
 
 after_test:
   # move coverage into the project dir to make default handling applicable

.github/workflows/docbuild.yml

@@ -12,9 +12,9 @@ jobs:
       run: |
         git config --global user.email "test@github.land"
         git config --global user.name "GitHub Almighty"
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v3
     - name: Set up Python 3.8
-      uses: actions/setup-python@v1
+      uses: actions/setup-python@v4
       with:
         python-version: 3.8
     - name: Install dependencies

.github/workflows/test_crippledfs.yml

@@ -27,11 +27,11 @@ jobs:
       run: |
         git config --global user.email "test@github.land"
         git config --global user.name "GitHub Almighty"
-    - uses: actions/checkout@v1
-    - name: Set up Python 3.6
-      uses: actions/setup-python@v1
+    - uses: actions/checkout@v3
+    - name: Set up Python 3.8
+      uses: actions/setup-python@v4
       with:
-        python-version: 3.6
+        python-version: 3.8
     - name: Install dependencies
       run: |
         pip install -r requirements-devel.txt
@@ -52,4 +52,4 @@ jobs:
         echo "== mount >>"
         mount
         echo "<< mount =="
-        python -m nose -s -v --with-doctest --with-coverage --cover-package datalad_xnat datalad_xnat
+        python -m pytest -s -v --cov=datalad_xnat --pyargs datalad_xnat

datalad_xnat/tests/test_init.py

@@ -14,15 +14,15 @@
     Dataset,
     xnat_init,
 )
-from datalad.tests.utils import (
+from datalad.tests.utils_pytest import (
     assert_result_count,
     with_tempfile,
 )
 from datalad.utils import Path
 
 
 @with_tempfile
-def test_invalid_url(dspath):
+def test_invalid_url(dspath=None):
 
     dspath = Path(dspath)
 

datalad_xnat/tests/test_nitrcir.py

@@ -14,7 +14,7 @@
     Dataset,
 )
 
-from datalad.tests.utils import (
+from datalad.tests.utils_pytest import (
     assert_equal,
     assert_in,
     assert_in_results,
@@ -86,7 +86,7 @@ def test_anonymous_access_platform():
 
 
 @with_tempfile
-def test_anonymous_access_api(path):
+def test_anonymous_access_api(path=None):
     # test command usage w/ anonymous access to nitrc-ir
 
     ds = Dataset(path).create()

datalad_xnat/tests/test_update.py

@@ -15,15 +15,15 @@
     xnat_update,
 )
 
-from datalad.tests.utils import (
+from datalad.tests.utils_pytest import (
     assert_in_results,
     with_tempfile,
 )
 
 from datalad_xnat.init import _cfg_dataset
 
 
-def fake_init(path):
+def fake_init(path=None):
     """Do whatever is needed to xnat-init() a fresh dataset without talking
     to a real XNAT instance
     """
@@ -43,7 +43,7 @@ def fake_init(path):
 
 
 @with_tempfile
-def test_invalid(path):
+def test_invalid(path=None):
     ds = fake_init(path)
     (ds.pathobj / 'dirty').write_text('dirt')
     # refuses to work on dirty datasets

datalad_xnat/tests/test_xnatcentral.py

@@ -14,7 +14,7 @@
     Dataset,
 )
 
-from datalad.tests.utils import (
+from datalad.tests.utils_pytest import (
     assert_equal,
     assert_in,
     assert_in_results,
@@ -86,7 +86,7 @@ def test_anonymous_access_platform():
 
 
 @with_tempfile
-def test_anonymous_access_api(path):
+def test_anonymous_access_api(path=None):
     # test command usage w/ anonymous access to xnatcentral
 
     ds = Dataset(path).create()

docs/source/conf.py

@@ -114,7 +114,7 @@
 todo_include_todos = True
 
 # Example configuration for intersphinx: refer to the Python standard library.
-intersphinx_mapping = {'https://docs.python.org/': None}
+intersphinx_mapping = {"python": ('https://docs.python.org/3', None)}
 
 # -- Options for HTML output ----------------------------------------------
 

requirements-devel.txt

@@ -1,5 +1,5 @@
 # requirements for a development environment
-nose
-coverage
+pytest
+pytest-cov
 sphinx
 sphinx_rtd_theme

setup.cfg

@@ -22,8 +22,8 @@ include_package_data = True
 [options.extras_require]
 # this matches the name used by -core and what is expected by some CI setups
 devel =
-    nose
-    coverage
+    pytest
+    pytest-cov
 
 [options.packages.find]
 # do not ship the build helpers