-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring up-to-date with extension template #151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bdist_wheel command in Makefile
Stop using distutils
Stop using `setup_requires`
Make version detection robust to GIT_DIR specification
With the command being in a dedicated file. Now also include standard logger naming suggestions. Fixes datalad/datalad-extension-template#27
Round of fixes and updates
Replace _metalad with _helloworld for easier grepping
Add documentation explainer
The removed code was previously unused and lived only as a side note two commits ago. It was suggested in issue #33 that datalad-neuroimaging is probably the only extension using this stage of doc-build, and therefore we may drop it from the template.
Starting with Sphinx version 5.0, the configuration for the doc's language should not be None anymore and causes docbuild failures otherwise (see datalad/datalad#6715). This change sets the language specification to English (en)
DOC: Set language in Sphinx config to en
Include "data packages" in projects
This is contingent on completion and release of migration over to pytest in datalad core which is ongoing in datalad/datalad#6273 which I think should happen in 0.17. We should strive to make that PR **not** break runtime (but can break testing) of extensions.
because we moved to pytest in 0.17.0 and even though 0.16.0 would already be good for python 3.7 I decided just to boost minimal datalad version because prior one is no longer maintained.
Replace os.system with subprocess.run in doc-build
RF: migrate to use pytest instead of nose, drop PY 3.6, require datalad >= 0.17.0
Done in -core and elsewhere. Closes datalad/datalad-extension-template#37
Move was done in datalad/datalad#7170
Account for move of @eval_results in datalad core
ENH: provide needed devel dependencies and devel-utils (with scriv)
=== Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
The "old" format of intersphinx_mapping is deprecated since Sphinx 6.2 and started causing warnings treated as errors in the doc build CI. https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html#confval-intersphinx_mapping As a side note, the intersphinx extension "can generate links to the documentation of objects in external projects". The changed config option is just an example, even a comment in the file says so. Personally I don't think we need the capability to link to Python project docs by default, and intersphinx could be removed altogether. But since it was here already, and it probably doesn't hurt, it shall remain in an updated format as of this commit.
Update intersphinx_mapping format
…ed in core fixes #62
Add basic readthedocs.yml configuration
Ci bumps: newer git annex and also python 3.8 not 3.7
codespell: config, dedicated workflow + 1 typo fix
Ref: datalad/datalad-next#446 and there on
Appveyor setup: use venv in favor of virtualenv
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…/checkout-4 [gh-actions](deps): Bump actions/checkout from 3 to 4
Closed
The test environment (at that time) does not have a sufficient XNAT configuration to survive an automated test. It would ask for the location of a target XNAT server interactively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146