update gh login instructions after gh CLI storage update #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As shared [in this comment](ejoffe#335 (comment)), gh cli has changed the default behavior of how github auth tokens are saved. This change makes spr no longer able to read github auth tokens and has caused myself and others confusion when instructions say to run `gh auth login` but still see spr not be able to find the token. This change updates the instructions to avoid this confusion. I do understand that suggesting to users to use insecure storage may not be ideal and a different solution may be preferred. Whatever solution it is, I believe it's better then today where users of spr receive these help docs, try them, and do not see success.
ejoffe
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shared in this comment, gh cli has changed the default behavior of how github auth tokens are saved. This change makes spr no longer able to read github auth tokens and has caused myself and others confusion when instructions say to run
gh auth loginbut still see spr not be able to find the token.This change updates the instructions to avoid this confusion. I do understand that suggesting to users to use insecure storage may not be ideal and a different solution may be preferred. Whatever solution it is, I believe it's better then today where users of spr receive these help docs, try them, and do not see success.