Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HIDPI variables and auto-scale feature for cheatsheet #336

Closed
wants to merge 2 commits into from

Conversation

jsl9208
Copy link

@jsl9208 jsl9208 commented Mar 16, 2024

This PR adds some HIDPI variables and uses them to automatically scale down the cheatsheet, making it usable on scaled screens. Takes effect on Hyprland.

Solves #283.

Tested 2880x1800, 2x scaled:
图片

1920x1080, 2x:
图片

@end-4
Copy link
Owner

end-4 commented Mar 17, 2024

this is really interesting... but why not have this for all windows? 🤔

@jsl9208
Copy link
Author

jsl9208 commented Mar 17, 2024

this is really interesting... but why not have this for all windows? 🤔

Sorry I didn't understand the question. You mean other widges? Only the cheatsheet and overview window looks way much bigger after scaled IMO.

@jsl9208
Copy link
Author

jsl9208 commented Mar 17, 2024

Fixing the issue with the overview window is simple. All that needs to be done is to change all occurrences of the variables such as SCREEN_* in its code to SCREEN_REAL_*. I'd like to work on it later.

@Mooling0602
Copy link

Mooling0602 commented Apr 16, 2024

Fixing the issue with the overview window is simple. All that needs to be done is to change all occurrences of the variables such as SCREEN_* in its code to SCREEN_REAL_*. I'd like to work on it later.

Hey bro, you may forgot to import { SCREEN_REAL_HEIGHT } in the .config/ags/modules/cheatsheet/main.js, so the change will be not complete.
But I can't fix this, so I need your help to improve this.

@jsl9208 jsl9208 closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants