-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Two finger panning is slow #7849
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
scrollX: zoomState.scrollX + 2 * (deltaX / nextZoom), | ||
scrollY: zoomState.scrollY + 2 * (deltaY / nextZoom), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 2x? Isn't this more related to devicePixelRatio
which on most mobile touchscreens would coincide with 2
?
All I can confirm is I deployed this change 6 weeks ago to Obsidian and since then I had received no complains. It works well for me on iPad and Android. Finally panning is as quick as with a mouse. |
Yeah, I was just wondering if there was a reasoning behind it, or it's just a magic number. I'll add a comment it's a magic number then. :) |
Thanks Zsolt! ❤️ |
fix #2497
fix #6913
With this change, two finger panning on iPad matches the single finger panning with the hand tool. I tested this with various zoom levels.
sorry - can't figure out how to update tests to accommodate the change :(