Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Kintex7 xc7k325 support (alternative) #1844

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

unbtorsten
Copy link

This is an attempt alternative to #1794. Differences are:

  • settings/kintex7_325t.sh defines a different tilegrid
  • orphan_int_column fuzzer is disabled for xc7k325t
  • configure fuzzers/005-tilegrid/generate_full.py to return if XRAY_IOI3_TILES is empty

This pull request is to determine whether changes pass automatic testing.

@mithro
Copy link
Contributor

mithro commented Feb 1, 2022

Looks like you need to rebase before I can test CI.

@unbtorsten
Copy link
Author

Looks like you need to rebase before I can test CI.

Indeed. Sorry about the hold-up. I finally managed the intended rebase.

Please note that this commit has been tested with DSP disabled for Kintex7. DSPs were enabled for all devices in #1816. If this turns out to be an issue for this PR, we could try deactivating the DSPs temporarily.

@mithro
Copy link
Contributor

mithro commented Feb 2, 2022

This is blocked by #1833

@acomodi / @kgugala - Can you get the CI fixed ASAP so this PR can be tested?

@acomodi
Copy link
Contributor

acomodi commented Feb 2, 2022

@mithro trying to do that in here #1845. Not sure how to convince kokoro to really use Ubuntu bionic or focal, as xenial does not have support for deadsnakes PPA that has python packages.

One of the other options I see is to move to GitHub custom runners

@unbtorsten
Copy link
Author

Are there any updates on the end of CI? Still waiting for this PR (or equivalently #1794) to be confirmed for merge.

@mithro
Copy link
Contributor

mithro commented Mar 2, 2022

@unbtorsten - Can you rebase this onto master so that the GitHub Action CI (which replaces kokoro) runs here?

@mithro
Copy link
Contributor

mithro commented Mar 2, 2022

Actually it looks like the GitHub Action stuff hasn't landed yet (see #1846) and Kokoro is currently borked #1833 -- Gah!?

Signed-off-by: Torsten Reuschel <torsten.reuschel@unb.ca>
Signed-off-by: Torsten Reuschel <torsten.reuschel@unb.ca>
Signed-off-by: Torsten Reuschel <torsten.reuschel@unb.ca>
…, since test returns empty list

Signed-off-by: Torsten Reuschel <torsten.reuschel@unb.ca>
…ase of empty list of IOI tiles

Signed-off-by: Torsten Reuschel <torsten.reuschel@unb.ca>
Signed-off-by: Torsten Reuschel <torsten.reuschel@unb.ca>
Signed-off-by: Torsten Reuschel <torsten.reuschel@unb.ca>
@unbtorsten
Copy link
Author

@unbtorsten - Can you rebase this onto master so that the GitHub Action CI (which replaces kokoro) runs here?

Done

@unbtorsten
Copy link
Author

Is CI still broken? How can we move forward with this?

@hansfbaier
Copy link
Collaborator

@unbtorsten They currently are working on getting the license working in the new GitHub actions based workflow

@hansfbaier
Copy link
Collaborator

#1918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants