Vivado accelerator axi master interface #683
Conversation
…r, and add _LOOP labels
…r, and add _LOOP labels
jmduarte
force-pushed
the
vivado-accelerator-axi-master-interface
branch
from
17c0fa5
to
109773c
Compare
jmduarte
added
enhancement
please test
…ights, it does not need loading weights in the AXI wrapper
jmduarte
added
please test
jmduarte
added
please test
| @@ -124,6 +131,23 @@ def write_axi_wrapper(self, model): | |||
| newline += indent + '#pragma HLS INTERFACE ap_ctrl_none port=return\n' | |||
| if model.config.get_config_value("IOType") == 'io_stream': | |||
| newline += indent + '#pragma HLS DATAFLOW\n' | |||
| elif '//hls-fpga-machine-learning insert load weights' in line: | |||
There was a problem hiding this comment.
I would strongly discourage this style of code in the writer. What's the point of templates if they are blank and all the logic is written by the writer? Just clutters the writer. This is much better addressed with a template that contains compile-time constants to select the functionality and just fill out the few lines with specific weights
There was a problem hiding this comment.
Isn't this a copy mainly from vivado_writer.py lines 130-139? Do they both need to change?
There was a problem hiding this comment.
@jmitrevs, yes I moved the code from the vivado_write.py to the vivado_accelerator_write.py.
| @@ -139,10 +163,12 @@ def write_axi_wrapper(self, model): | |||
| newline += indent + '}\n' | |||
| elif io_type == 'io_stream': | |||
| newline = '' | |||
| newline += 'LOAD_INPUT_OUTER_LOOP:\n' | |||
There was a problem hiding this comment.
Also, can we remove the explicit creation of loops and move that to the template, as suggested above?
| @@ -188,6 +216,35 @@ def write_axi_wrapper(self, model): | |||
| f.close() | |||
| fout.close() | |||
|
|
|||
| def modify_project_cpp(self, model): | |||
There was a problem hiding this comment.
Lol. Just add a flag to not write the interface in the VivadoWriter instead of this approach.
| @@ -37,10 +37,10 @@ def print_array_to_cpp(self, var, odir, write_txt_file=True): | |||
|
|
|||
| if write_txt_file: | |||
| h_file.write("#ifndef __SYNTHESIS__\n") | |||
| h_file.write(var.definition_cpp() + ";\n") | |||
| h_file.write("static " + var.definition_cpp() + ";\n") | |||
There was a problem hiding this comment.
- Why at all?
- Why like this and not in
definition_cpp()?
|
|
||
| def predict(self, X, debug=False, profile=False, encode=None, decode=None): | ||
| """ | ||
| Obtain the predictions of the NN implemented in the FPGA. |
There was a problem hiding this comment.
Can we convert this docstring to Google style, like is used elsewhere in the code?
jmduarte
added
please test
Description
🐥 👉 Creating a new PR to allow edits from maintainers. Previous PR. 👈 🐥
Extend the VivadoAccelerator backend to support AXI-m data movers for inputs and outputs. An ideal setup is a Xilinx Zynq/ZynqMP board (ARM core + programmable logic).
The backend generates the Python drivers for Pynq-Z2.
Tests
You can test it with this example on Pynq-Z2.